Skip to content

Update overview.md #2916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update overview.md #2916

wants to merge 2 commits into from

Conversation

CMSMartinK
Copy link

@CMSMartinK CMSMartinK commented Apr 16, 2025

added info about complex properties under "Model Requirements". I spent about 6hrs trying to figure this out, so please add it to the docs.

Note to external contributors: make sure to sign our Contribution License Agreement (CLA) for Blazor UI first:

https://forms.office.com/Pages/ResponsePage.aspx?id=Z2om2-DLJk2uGtBYH-A1NbWxVqugKN5DvVp8I-1AgOBURFBVSkwyMlA1TkFDVFdMNU1aM1o1UlZQOC4u

(signed)

added info about complex properties under "Model Requirements"
@CMSMartinK CMSMartinK requested review from a team as code owners April 16, 2025 10:00
ikoevska
ikoevska previously approved these changes Apr 17, 2025
@@ -36,8 +36,9 @@ Adding or editing rows in the Grid sets the following requirements on the Grid m

* The Grid model class must have a parameterless constructor. Otherwise, use the [Grid `OnModelInit` event](slug:grid-events#onmodelinit) to provide a data item instance [when the Grid needs to create one](#item-instances). Optinally, you can also [set some default values](slug://grid-kb-default-value-for-new-row).
* All editable properties must be `public` and have setters. These properties must not be `readonly`.
* All complex properties, that are used in the grid, must be instantiated in [Grid `OnModelInit` event](slug:grid-events#onmodelinit).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* All complex properties, that are used in the grid, must be instantiated in [Grid `OnModelInit` event](slug:grid-events#onmodelinit).
* All complex properties used in the Grid must be instantiated in the [Grid `OnModelInit` event](slug://grid-events#onmodelinit).

@ikoevska ikoevska dismissed their stale review April 17, 2025 08:16

External contribution, should not pre-approve before all required changes are applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants