Skip to content

fix(workflow): Properly wait for vm microtasks #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 12, 2022
Merged

Conversation

bergundy
Copy link
Member

Use microtaskMode=afterEvaluate to ensure isolateExecutionTimeoutMs
includes microtask processing too.

Use microtaskMode=afterEvaluate to ensure `isolateExecutionTimeoutMs`
includes microtask processing too.
@bergundy bergundy requested a review from lorensr March 10, 2022 02:01
@bergundy bergundy self-assigned this Mar 11, 2022
@lorensr
Copy link
Contributor

lorensr commented Mar 12, 2022

Tests are passing locally.

@lorensr lorensr merged commit 6e65a57 into main Mar 12, 2022
@lorensr lorensr deleted the vm-wait-microtasks branch March 12, 2022 04:31
lorensr added a commit that referenced this pull request Mar 12, 2022
Use microtaskMode=afterEvaluate to ensure `isolateExecutionTimeoutMs`
includes microtask processing too.

Co-authored-by: Loren ☺️ <[email protected]>
Co-authored-by: Loren 🤓 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants