This repository was archived by the owner on Mar 18, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 120
Rerun Functionality #30
Closed
Closed
Changes from 5 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
6089cca
Added files via upload
sugatmankar 0cd8469
Added files via upload
sugatmankar 44e433f
Added files via upload
sugatmankar 735a6f2
Update readme.md
sugatmankar 9ab1694
Update readme.md
sugatmankar 2f00929
update pom.xml
sugatmankar f4ea3c1
Update ClassNameGenerator.java
sugatmankar ec0c6a9
Update CucumberITGenerator.java
sugatmankar 2f0f1e9
Update FileGeneratorConfig.java
sugatmankar 659d48b
Update GenerateRunnersMojo.java
sugatmankar b5697c0
Update OverriddenCucumberOptionsParameters.java
sugatmankar 9c2ade6
Update OverriddenRerunOptionsParameters.java
sugatmankar 5473d35
Update ExtendedRuntimeOptions.java
sugatmankar bcc6b92
Update RuntimeOptions.java
sugatmankar 7e78e8c
Update cucumber-junit-re-runner.vm
sugatmankar 13a8d22
resolve conflicts 1.3.0
sugatmankar 9553896
removed preveous conflicts
sugatmankar a47a9d7
Merge branch 'master' of https://github.com/sugatmankar/cucumber-jvm-…
sugatmankar ec19229
new changes 1.3.0
sugatmankar 3841989
added 1.3.0
sugatmankar 6aba3c9
thread count updated in pom.xml
sugatmankar cfa938b
added missing classes
sugatmankar f5f079c
update pom.xml
sugatmankar 638f712
Update Readme
sugatmankar 882eacd
Update README.md
sugatmankar 994817e
updated retryCount default value to 0
sugatmankar e70679a
Merge https://github.com/temyers/cucumber-jvm-parallel-plugin
sugatmankar e41d629
updated junit retry param and JUnitRetryCount property
sugatmankar 7000316
removed junit-rerun it
50a9134
Updated README.md: removed unused property useJunitRerun
5254839
resolved checkstyle conflicts and junit-rerun it runner
sugatmankar de5502a
resolved checkstyle conflicts and junit-rerun it runner
sugatmankar 3f57165
resolved checkstyle errors
sugatmankar 7f49f96
added feature files under junit-rerun
sugatmankar fff7b84
added tagwise gen logic
sugatmankar bb8525b
changes for tagwise run
sugatmankar 9ecd7fa
removed tmp _jb_tmp file
sugatmankar 17af7c7
thread count pom.xml
sugatmankar 033f8ae
Update custom-output-directory-verify-groovy
sugatmankar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 changes: 38 additions & 37 deletions
75
src/main/java/com/github/timm/cucumber/generate/ClassNameGenerator.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,37 +1,38 @@ | ||
package com.github.timm.cucumber.generate; | ||
|
||
import com.google.common.base.CaseFormat; | ||
import org.apache.commons.io.FilenameUtils; | ||
|
||
import java.util.regex.Matcher; | ||
import java.util.regex.Pattern; | ||
|
||
public class ClassNameGenerator { | ||
|
||
Pattern startsWithDigit = Pattern.compile("^\\d.*"); | ||
|
||
public String generateClassNameFromFeatureFileName(String featureFileName, int fileCounter) { | ||
|
||
String fileNameWithNoExtension= FilenameUtils.removeExtension(featureFileName); | ||
|
||
fileNameWithNoExtension=fileNameWithNoExtension.replaceAll("_","-"); | ||
fileNameWithNoExtension=fileNameWithNoExtension.replaceAll(" ",""); | ||
|
||
String className = CaseFormat.LOWER_HYPHEN.to(CaseFormat.UPPER_CAMEL, fileNameWithNoExtension); | ||
|
||
Matcher startsWithDigitCheck = startsWithDigit.matcher(className); | ||
|
||
if(startsWithDigitCheck.matches()){ | ||
className="_"+className; | ||
} | ||
|
||
return String.format(className+"%02dIT.java",fileCounter); | ||
} | ||
|
||
public String generateSimpleClassName(int fileCounter) { | ||
|
||
return String.format("Parallel%02dIT.java",fileCounter); | ||
|
||
} | ||
|
||
} | ||
package com.github.temyers.generate; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks like you're using a different formatter. What IDE are you using? Please could you reconcile - it makes reviewing much easier (I realise I haven't defined a standard so far) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry for that mistake. I am using Intellij IDEA 14.1.1 . will fix this as soon as possible. |
||
|
||
import com.google.common.base.CaseFormat; | ||
import org.apache.commons.io.FilenameUtils; | ||
|
||
import java.util.regex.Matcher; | ||
import java.util.regex.Pattern; | ||
|
||
/** | ||
* Created by cwr.sugad.mankar on 5/4/2016. | ||
*/ | ||
public class ClassNameGenerator { | ||
Pattern startsWithDigit = Pattern.compile("^\\d.*"); | ||
|
||
public String generateClassNameFromFeatureFileName(String featureFileName, int fileCounter) { | ||
|
||
String fileNameWithNoExtension= FilenameUtils.removeExtension(featureFileName); | ||
|
||
fileNameWithNoExtension=fileNameWithNoExtension.replaceAll("_","-"); | ||
fileNameWithNoExtension=fileNameWithNoExtension.replaceAll(" ",""); | ||
|
||
String className = CaseFormat.LOWER_HYPHEN.to(CaseFormat.UPPER_CAMEL, fileNameWithNoExtension); | ||
|
||
Matcher startsWithDigitCheck = startsWithDigit.matcher(className); | ||
|
||
if(startsWithDigitCheck.matches()){ | ||
className="_"+className; | ||
} | ||
|
||
return String.format(className+"%02dIT.java",fileCounter); | ||
} | ||
|
||
public String generateSimpleClassName(int fileCounter) { | ||
|
||
return String.format("Parallel%02dIT.java",fileCounter); | ||
|
||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, there are now two properties defining which template to use: useTestNG and useReRun.
This adds complication - should rerun + testNG be supported together?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't try for TestNG. Once i'm done with current changes. Will look for TestNG as well. :)