Add default methods to Operand to get the shape and datatype from asOutput(). #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Output()`. Signed-off-by: Ryan Nett <[email protected]>
karllessard
reviewed
Nov 16, 2020
| /** | ||
| * Returns the build-time shape of this operand. May be only partially known. | ||
| */ | ||
| default Shape shape(){ |
There was a problem hiding this comment.
I guess we want to mark the same methods in Output as overrides now (@Override) and probably inherit the javadoc
karllessard
requested changes
Nov 16, 2020
There was a problem hiding this comment.
Thanks for the PR @rnett, just a small change and then we are good
|
@rnett , I've started to create PRs for the type-system refactoring (see #139) and the first one (#153) partially covers the changes in your PR, but wrt the new design. Plus, the addition of Therefore, I would like to see if you would agree to close your PR to avoid any conflict. |
|
I saw that, it's fine by me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add default methods to Operand to get the shape and datatype from
asOutput().Fixes #146.