[Type Refactor] Move type implementations and mappers to internal package #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karllessard
force-pushed
the
type-refactor-mappers
branch
from
50ef157 to
f4b6fe3
Compare
Craigacp
requested changes
Dec 18, 2020
tensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/TensorMapper.java
Show resolved
Hide resolved
...low-core/tensorflow-core-api/src/main/java/org/tensorflow/internal/buffer/ByteSequencer.java
Outdated
Show resolved
Hide resolved
...ow-core/tensorflow-core-api/src/main/java/org/tensorflow/internal/types/TBfloat16Mapper.java
Outdated
Show resolved
Hide resolved
...rflow-core/tensorflow-core-api/src/main/java/org/tensorflow/internal/types/TInt64Mapper.java
Outdated
Show resolved
Hide resolved
...rflow-core/tensorflow-core-api/src/main/java/org/tensorflow/internal/types/TInt64Mapper.java
Outdated
Show resolved
Hide resolved
tensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/types/TBfloat16.java
Show resolved
Hide resolved
tensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/types/TBool.java
Show resolved
Hide resolved
karllessard
changed the title
karllessard
changed the title
|
Thanks a lot @Craigacp for this quick review! |
rnett
pushed a commit
to rnett/tensorflow-java
that referenced
this pull request
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this relatively-simple PR, I move the implementations of the typed tensors (
TType) and their mapping method to the internal package as separate objects.While the reason for doing it might seem unclear at this point, it will make more sense in the next PR where the
*Mapperclass could be referenced from a new@TensorTypeannotation. In addition, segregating the implementation classes from their respective interfaces is more scalable for when we'll start supporting different categories of tensors, like sparse and ragged.Note that these changes has no impact on the user API and is completely backward compatible.
CC\ @deansher