-
Notifications
You must be signed in to change notification settings - Fork 214
Metrics Phase 1 #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Metrics Phase 1 #180
Changes from 3 commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
c57a2e7
Merge pull request #3 from tensorflow/master
JimClarke5 09fc07e
Merge pull request #4 from tensorflow/master
JimClarke5 a99dcb4
Merge pull request #5 from tensorflow/master
JimClarke5 ba294ea
Merge pull request #6 from tensorflow/master
JimClarke5 04f419a
Merge pull request #7 from tensorflow/master
JimClarke5 ad466ee
Initial checkin
JimClarke5 092b47d
Initial checkin and sync with master
JimClarke5 4887b5b
Initial checkin and sync with master
JimClarke5 04eeea6
JavaDoc cleanup
JimClarke5 dcb2414
Javadoc fixes
JimClarke5 82f18bf
Change LossInterface to LossMetric.
JimClarke5 9aa1511
Removed hashmap for variables, they are not needed as the variables o…
JimClarke5 1097722
reformat code
JimClarke5 bc0f468
Add tests for assertBroadcastable
JimClarke5 41876d5
Change type to resultType
JimClarke5 61af528
Added V data type for sampleWeights so that it is not forced to be th…
JimClarke5 c121c07
change 'type' to 'resultType'
JimClarke5 e9ee98f
clean up mean and fix assert assertBroadcastable
JimClarke5 9788983
fix error message
JimClarke5 8857a66
Change sampleWeights to have its own generic type <S extends TNumber>
JimClarke5 34a779f
Add commment about invalid tests expecting IllegalArgumentExceptions
JimClarke5 748f16d
Add this exception instead of the more generic IllegalArgumentExcepti…
JimClarke5 212541b
change IllegalArgumentException to NotBroadcastableException.
JimClarke5 f0d72d2
reformat code
JimClarke5 8b49c60
Fis=x Javadoc
JimClarke5 20c6e98
Fix Reduce to use boradcastWeights,
JimClarke5 d3d7ee9
Added comment to count to indicate that it may be weighted.
JimClarke5 fe86b0b
Added SetsOps and fixed AssertBroadcastable to use SetsOps methods,
JimClarke5 0edd114
Fixed based on various PR comments.
JimClarke5 7d78fd3
Deleted, no longer needed after change to Variable handling in Metrics.
JimClarke5 02e7ebf
Merge pull request #8 from tensorflow/master
JimClarke5 af1b49f
Nicer error messages for mode-forbidden ops (#169)
rnett 7732601
Initialization imprvements (#178)
rnett a737334
Clairify tensorOf lifetime requirements (#190)
rnett 253cc73
Remove extra generics from op generation (#193)
rnett 22cb5b2
Add Java 11 support - Initial Phase (#185)
JimClarke5 4d1aa20
Update manual ops for new codegen (#196)
rnett 2b7f6ed
Fix Losses to use CHANNELS_FIRST/LAST for CategoricalCrossentropy
JimClarke5 3800b71
Fix SetOps to properly convert sparse tensor to dense tensor using tf…
JimClarke5 3045999
Initial checkin
JimClarke5 9eb5adf
Initial checkin and sync with master
JimClarke5 187c17c
Initial checkin and sync with master
JimClarke5 050fe28
JavaDoc cleanup
JimClarke5 b640406
Javadoc fixes
JimClarke5 3715513
Change LossInterface to LossMetric.
JimClarke5 a1c1976
Removed hashmap for variables, they are not needed as the variables o…
JimClarke5 6641fca
reformat code
JimClarke5 fa76043
Add tests for assertBroadcastable
JimClarke5 e136f4d
Change type to resultType
JimClarke5 e00f2ef
Added V data type for sampleWeights so that it is not forced to be th…
JimClarke5 bc6c64b
change 'type' to 'resultType'
JimClarke5 02da963
clean up mean and fix assert assertBroadcastable
JimClarke5 44cdc35
fix error message
JimClarke5 49370b9
Change sampleWeights to have its own generic type <S extends TNumber>
JimClarke5 24b4125
Add commment about invalid tests expecting IllegalArgumentExceptions
JimClarke5 43c6b7b
Add this exception instead of the more generic IllegalArgumentExcepti…
JimClarke5 78e9dab
change IllegalArgumentException to NotBroadcastableException.
JimClarke5 5508969
reformat code
JimClarke5 c662524
Fis=x Javadoc
JimClarke5 512a153
Fix Reduce to use boradcastWeights,
JimClarke5 0663c3c
Added comment to count to indicate that it may be weighted.
JimClarke5 122e06b
Added SetsOps and fixed AssertBroadcastable to use SetsOps methods,
JimClarke5 b7b14b1
Fixed based on various PR comments.
JimClarke5 13639d3
Deleted, no longer needed after change to Variable handling in Metrics.
JimClarke5 561322f
Fix Losses to use CHANNELS_FIRST/LAST for CategoricalCrossentropy
JimClarke5 2a13012
Fix SetOps to properly convert sparse tensor to dense tensor using tf…
JimClarke5 36f3a69
Merge remote-tracking branch 'upstream/metrics1' into metrics1
JimClarke5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
125 changes: 0 additions & 125 deletions
125
tensorflow-framework/src/main/java/org/tensorflow/framework/metrics/impl/MetricVariable.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we should standardize on "similarity" or "proximity"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vote that we make Metrics
CosineSimularity
and for lossesCosineSimularityLoss
. My justification was previously mentioned in this thread.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it.