Skip to content

Fix TypeError when calculating normalized_error #8722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

ian-cannon
Copy link
Contributor

@ian-cannon ian-cannon commented Jun 23, 2020

Update agent.py according to changes noted #7719
to overcome the following error:
TypeError: x and y must have the same dtype, got tf.float32 != tf.float64 In call to configurable 'train_uvf' (<function train_uvf at 0x7f0b2e5ef320>)

Description

📝 Please include a summary of the change.

  • Please also include relevant motivation and context.
  • List any dependencies that are required for this change.

Type of change

For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.

Note: Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update
  • TensorFlow 2 migration
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • A new research paper code implementation
  • Other (Specify)

Tests

📝 Please describe the tests that you ran to verify your changes.

  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Test Configuration:

Checklist

Update agent.py according to changes noted tensorflow#7719
@ian-cannon ian-cannon requested a review from ofirnachum as a code owner June 23, 2020 14:45
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ian-cannon
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@ian-cannon ian-cannon changed the title Update agent.py Fix TypeError when calculating normalized_error Jun 23, 2020
@ofirnachum ofirnachum merged commit b9a87a5 into tensorflow:master Jun 23, 2020
kmindspark pushed a commit to kmindspark/models that referenced this pull request Jul 19, 2020
Update agent.py according to changes noted tensorflow#7719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants