Skip to content

Expectation layer won't work with remote simulators #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zaqqwerty opened this issue Feb 24, 2021 · 1 comment · Fixed by #513
Closed

Expectation layer won't work with remote simulators #490

zaqqwerty opened this issue Feb 24, 2021 · 1 comment · Fixed by #513
Assignees
@zaqqwerty

Comments

@zaqqwerty
Copy link
Contributor

zaqqwerty commented Feb 24, 2021 •
edited
Loading

Currently, the Expectation layer requires a cirq.SimulatesFinalState, see this line. Instead, it should be updated to directly call the methods in the new Cirq class cirq.SimulatesExpectationValues.
@MichaelBroughton
Copy link
Collaborator

Do you have any more information on the errors they are seeing or an example that reproduces things ?

@zaqqwerty zaqqwerty changed the title SampledExpectation layer won't work with remote simulators SampledExpectation and Expectation layers won't work with remote simulators Mar 17, 2021
@zaqqwerty zaqqwerty self-assigned this Mar 17, 2021
@zaqqwerty zaqqwerty changed the title SampledExpectation and Expectation layers won't work with remote simulators Expectation layer won't work with remote simulators Mar 17, 2021
@zaqqwerty zaqqwerty mentioned this issue Mar 24, 2021
Merged
jaeyoo pushed a commit to jaeyoo/quantum that referenced this issue Mar 30, 2023
@MichaelBroughton
Merge pull request tensorflow#490 from MichaelBroughton/mps_sample
79197f9 
Adds working bitstring Sample function to MPS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zaqqwerty zaqqwerty

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make expectation op accept SimulatesExpectationValues zaqqwerty/quantum
2 participants
@MichaelBroughton @zaqqwerty