This repository was archived by the owner on Apr 23, 2025. It is now read-only.
add presubmit_build.sh that passes a flag to swiftpm if it is a stock toolchain #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BradLarson
reviewed
Dec 17, 2020
docker/presubmit_build.sh
Outdated
Comment on lines
34
to
35
| swift build ${STOCK_TOOLCHAIN:+"-D -Xswiftc -D TENSORFLOW_USE_STANDARD_TOOLCHAIN"} ; | ||
| swift test ${STOCK_TOOLCHAIN:+"-D -Xswiftc -D TENSORFLOW_USE_STANDARD_TOOLCHAIN"} ; |
There was a problem hiding this comment.
I think there might be an extra -D in both of these. Should it just be "-Xswiftc -D TENSORFLOW_USE_STANDARD_TOOLCHAIN"?
There was a problem hiding this comment.
Good catch. And there should also be another -Xswiftc, right?
There was a problem hiding this comment.
I think just the one is needed if you smoosh the last two together into "-Xswiftc -DTENSORFLOW_USE_STANDARD_TOOLCHAIN". That works for me at the command line.
There was a problem hiding this comment.
But I tried what you have now with the two of them, and that also works well.
BradLarson
approved these changes
Dec 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I copied this from the internal script in google3, and modified it to pass a flag when building with a stock toolchain.
I'll also make a CL that deletes the script from google3 and calls this one instead.