This repository was archived by the owner on Jul 7, 2023. It is now read-only.
Enhance WMT17 En-Zh task with full dataset. #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix tensorflow#446 Added `file_size_budget` as argument to `get_or_generate_vocab`.
rsepassi
suggested changes
Dec 19, 2017
|
|
||
| @registry.register_problem | ||
| class TranslateEnzhWmt8k(translate.TranslateProblem): |
There was a problem hiding this comment.
let's keep an 8k version and add a 32k version. target vocab size should be part of the problem name.
| @@ -72,17 +169,32 @@ def source_vocab_name(self): | |||
| @property | |||
| def target_vocab_name(self): | |||
| return "vocab.enzh-zh.%d" % self.targeted_vocab_size | |||
|
|
|||
| def get_training_dataset(self, tmp_dir): | |||
| """UN Parallel Corpus and CWMT Corpus need to be downloaded manually. | |||
There was a problem hiding this comment.
could you provide instructions somewhere for how to download these manually?
- Added TranslateEnzhWmt8k problem. - Renamed to TranslateEnzhWmt32k, to reflect target vocab in problem name - Added instructions for manually downloading full dataset.
|
@rsepassi I've made the requested changes, hope this is ok! |
rsepassi
approved these changes
Jan 9, 2018
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds full dataset to
TranslateEnzhWmtif available.The UN parallel corpus, and CWMT corpus need to be downloaded from official website after registering. We add instructions to add the downloaded datasets manually to e.g.
/tmp/t2t_datagen/dataset.tgzand add code to append to full training dataset if available.Fix #446 Added
file_size_budgetas argument toget_or_generate_vocab.