Skip to content

Commit 31aa0ac

Browse files
authored
Linked Time: Enable Linked Time (#6137)
## Motivation for features / changes This feature is complete and we would like people to use it ## Technical description of changes The Linked Time feature is controlled by 4 feature flags: * `enabledScalarDataTable` * `enabledLinkedTime` * `allowRangeSelection` * `enabledProspectiveFob` ## Screenshots of UI changes Settings Panel: ![image](https://user-images.githubusercontent.com/78179109/211650399-ad62bb7f-297a-4724-9d43-d20e65c8d965.png) Prospective Fob: ![image](https://user-images.githubusercontent.com/78179109/211650663-e935c18c-a1de-4e51-acb6-28b2b34e3c67.png) Data Table with Range Selection: ![image](https://user-images.githubusercontent.com/78179109/211650966-318c3097-f1d7-4827-a35e-1ff17249cb96.png) ## Detailed steps to verify changes work correctly (as executed by you) 1) Start TensorBoard 2) Navigate to `localhost:6006` (Note the lack of feature flags) 3) Ensure the settings panel contains the step selection, range selection, and linked time checkboxes 4) Hover a scalar card X Axis 5) Assert a fob with a border appears 6) Click that fob 7) Assert a permanent fob is created there 8) Assert the table appears on that card 9) Assert you can create a second fob in the same way as the first 10) Click the "Link By Step" checkbox in the settings panel 11) Assert the step selectors on all the fobs jump to the same steps CC: [japie1235813](https://github.com/japie1235813), [bmd3k](https://github.com/bmd3k)
1 parent 7bcc5e8 commit 31aa0ac

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

tensorboard/webapp/feature_flag/store/feature_flag_metadata.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,12 @@ export const FeatureFlagMetadataMap: FeatureFlagMetadataMapType<FeatureFlags> =
7474
parseValue: parseStringArray,
7575
},
7676
enabledLinkedTime: {
77-
defaultValue: false,
77+
defaultValue: true,
7878
queryParamOverride: 'enableLinkedTime',
7979
parseValue: parseBoolean,
8080
},
8181
enabledScalarDataTable: {
82-
defaultValue: false,
82+
defaultValue: true,
8383
queryParamOverride: 'enableDataTable',
8484
parseValue: parseBoolean,
8585
},
@@ -116,12 +116,12 @@ export const FeatureFlagMetadataMap: FeatureFlagMetadataMapType<FeatureFlags> =
116116
parseValue: parseBoolean,
117117
},
118118
allowRangeSelection: {
119-
defaultValue: false,
119+
defaultValue: true,
120120
queryParamOverride: 'allowRangeSelection',
121121
parseValue: parseBoolean,
122122
},
123123
enabledProspectiveFob: {
124-
defaultValue: false,
124+
defaultValue: true,
125125
queryParamOverride: 'enableProspectiveFob',
126126
parseValue: parseBoolean,
127127
},

0 commit comments

Comments
 (0)