Linked Time: Enable Linked Time #6137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤦♂️ I forgot to push the commit |
JamesHollyer
approved these changes
Jan 11, 2023
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
## Motivation for features / changes This feature is complete and we would like people to use it ## Technical description of changes The Linked Time feature is controlled by 4 feature flags: * `enabledScalarDataTable` * `enabledLinkedTime` * `allowRangeSelection` * `enabledProspectiveFob` ## Screenshots of UI changes Settings Panel:  Prospective Fob:  Data Table with Range Selection:  ## Detailed steps to verify changes work correctly (as executed by you) 1) Start TensorBoard 2) Navigate to `localhost:6006` (Note the lack of feature flags) 3) Ensure the settings panel contains the step selection, range selection, and linked time checkboxes 4) Hover a scalar card X Axis 5) Assert a fob with a border appears 6) Click that fob 7) Assert a permanent fob is created there 8) Assert the table appears on that card 9) Assert you can create a second fob in the same way as the first 10) Click the "Link By Step" checkbox in the settings panel 11) Assert the step selectors on all the fobs jump to the same steps CC: [japie1235813](https://github.com/japie1235813), [bmd3k](https://github.com/bmd3k)
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
## Motivation for features / changes This feature is complete and we would like people to use it ## Technical description of changes The Linked Time feature is controlled by 4 feature flags: * `enabledScalarDataTable` * `enabledLinkedTime` * `allowRangeSelection` * `enabledProspectiveFob` ## Screenshots of UI changes Settings Panel:  Prospective Fob:  Data Table with Range Selection:  ## Detailed steps to verify changes work correctly (as executed by you) 1) Start TensorBoard 2) Navigate to `localhost:6006` (Note the lack of feature flags) 3) Ensure the settings panel contains the step selection, range selection, and linked time checkboxes 4) Hover a scalar card X Axis 5) Assert a fob with a border appears 6) Click that fob 7) Assert a permanent fob is created there 8) Assert the table appears on that card 9) Assert you can create a second fob in the same way as the first 10) Click the "Link By Step" checkbox in the settings panel 11) Assert the step selectors on all the fobs jump to the same steps CC: [japie1235813](https://github.com/japie1235813), [bmd3k](https://github.com/bmd3k)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
This feature is complete and we would like people to use it
Technical description of changes
The Linked Time feature is controlled by 4 feature flags:
enabledScalarDataTableenabledLinkedTimeallowRangeSelectionenabledProspectiveFobScreenshots of UI changes
Settings Panel:
Prospective Fob:
Data Table with Range Selection:
Detailed steps to verify changes work correctly (as executed by you)
localhost:6006(Note the lack of feature flags)CC: japie1235813, bmd3k