You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
HParams: Make icons buttons in data table header (#6594)
## Motivation for features / changes
To allow for tabbing to buttons and for general best practice clickable
elements should be buttons. So the 3 dot menu button was changed into a
button instead of a div. For sorting the entire header is clickable. We
did not want to make the entire header a button so I turned the sorting
icon into a button.
I also made some styling changes to spread out the icons and make them
easier to click.
## Technical description of changes
When I made the sorting icon a button I had to add the click event to
make it sort. I also had to stop propagation so the header's click event
was not fired.
## Screenshots of UI changes (or N/A)

0 commit comments