HParams: Make icons buttons in data table header #6594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHollyer
force-pushed
the
RunsHeaderTargetCleanup
branch
from
99ac5a4 to
d9e0023
Compare
JamesHollyer
force-pushed
the
RunsHeaderTargetCleanup
branch
from
d9e0023 to
7046db6
Compare
bmd3k
approved these changes
Sep 25, 2023
| *ngIf="(header.removable || header.sortable) && !disableContextMenu" | ||
| class="context-menu-container show-on-hover" | ||
| (click)="onContextMenuOpened($event)" |
There was a problem hiding this comment.
When I press "space" on this context menu, the context menu is actually opened in the top-left corner of the runs table rather than next to the location of the button.
Is there any way to fix this? Maybe take into account the location of the button when opening the context menu?
There was a problem hiding this comment.
Yea I noticed this too I added a task to fix it in our task list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
To allow for tabbing to buttons and for general best practice clickable elements should be buttons. So the 3 dot menu button was changed into a button instead of a div. For sorting the entire header is clickable. We did not want to make the entire header a button so I turned the sorting icon into a button.
I also made some styling changes to spread out the icons and make them easier to click.
Technical description of changes
When I made the sorting icon a button I had to add the click event to make it sort. I also had to stop propagation so the header's click event was not fired.
Screenshots of UI changes (or N/A)