Skip to content

Create a pb implementation for the pr curves plugin. #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chihuahua opened this issue Aug 30, 2017 · 0 comments
Closed

Create a pb implementation for the pr curves plugin. #445

chihuahua opened this issue Aug 30, 2017 · 0 comments
Assignees
@chihuahua
Labels
plugin:pr-curves type:feature

Comments

@chihuahua
Copy link
Member

chihuahua commented Aug 30, 2017 •
edited
Loading

That would enable developers outside of TensorFlow to use the PR curves plugin. Other plugins have a pb implementation (that differs from the op implementation, which is a TensorFlow op).
@chihuahua chihuahua self-assigned this Aug 30, 2017
@wchargin wchargin mentioned this issue Sep 26, 2017
Merged
@chihuahua chihuahua mentioned this issue Oct 10, 2017
Merged
chihuahua added a commit to chihuahua/tensorboard that referenced this issue Oct 10, 2017
@chihuahua
Add pb method for PR curves
b840408 
This change adds a `pb` implementation for the PR curves summary, which, like all `pb` implementations, lets users generate summaries without having to use TensorFlow.

Also modified the test for PR curve summaries to use small test cases
that are easy for a developer to reason through instead of using the
demo data. This allows us to use the compute_and_check_summary_pb
paradigm for the PR curves summary test, just like for other plugins.

Updated the summary module to include `pr_curve_pb`. Fixes tensorflow#445.
chihuahua added a commit that referenced this issue Oct 13, 2017
@chihuahua
Add pb method for PR curves (#633)
18b7e41 
This change adds a `pb` implementation for the PR curves summary,
which, like all `pb` implementations, lets users generate summaries
without having to use TensorFlow.

Also modified the test for PR curve summaries to use small test cases
that are easy for a developer to reason through instead of using the
demo data. This allows us to use the `compute_and_check_summary_pb`
paradigm for the PR curves summary test, just like for other plugins.

Updated the summary module to include `pr_curve_pb`. Fixes #445.

As part of this change, renamed the `tag` parameter of summary ops to
`name` to be consistent with other summaries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chihuahua chihuahua

Labels
plugin:pr-curves type:feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teamdandelion @chihuahua