Remove the demoify function
#490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We don’t support the demo mode at all, nor do we have any plans to. This function is complicating our logic and getting in the way of things that we actually want to do, so out it goes. Note that this commit does not remove “demo mode” entirely: the router still has `demoMode`, and I didn’t go through and remove all of its uses. (But that’s not a bad idea, and there are only a handful.) Test Plan: I tested that the image and audio dashboards still properly load images and audio. Changes to the test are not tested, as we don’t run tests. wchargin-branch: remove-demoify
wchargin
force-pushed
the
wchargin-remove-demoify
branch
from
b9ce895 to
87c01f7
Compare
chihuahua
approved these changes
Sep 8, 2017
|
Cool, that would be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We don’t support the demo mode at all, nor do we have any plans to. This
function is complicating our logic and getting in the way of things that
we actually want to do, so out it goes.
Note that this commit does not remove “demo mode” entirely: the router
still has
demoMode, and I didn’t go through and remove all of itsuses. (But that’s not a bad idea, and there are only a handful.)
Test Plan:
I tested that the image and audio dashboards still properly load images
and audio. Changes to the test are not tested, as we don’t run tests.
wchargin-branch: remove-demoify