Use addParams where it would improve code
#491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, it looks like Eventual Consistency Wins Again. This PR is supposed to come before #492. |
wchargin
force-pushed
the
wchargin-use-add-params
branch
2 times, most recently
from
00a39dc to
060abf6
Compare
wchargin
force-pushed
the
wchargin-add-params
branch
from
90afe93 to
151112b
Compare
wchargin
force-pushed
the
wchargin-use-add-params
branch
from
060abf6 to
7cecc1c
Compare
wchargin
force-pushed
the
wchargin-add-params
branch
2 times, most recently
from
aa77ba5 to
f79f72f
Compare
Summary: This commit replaces uses like `base + "?things"` (when `base` is not known to not already contain a query component), or that fail to call `encodeURIComponent` on the `things`, with uses of `addParams`. I generated this commit by running `git grep '[&?].*='` and investigating each occurrence. I ignored all occurrences in the graph and projector plugins, as they have their own mini-ecosystems. I also ignored the unique occurrence in the profile plugin, because (a) I can’t test it, and (b) its inputs are hard-coded such that this change provably would not fix any bugs. Test Plan: I verified the behavior of all existing plugins. wchargin-branch: use-add-params
wchargin
force-pushed
the
wchargin-use-add-params
branch
from
7cecc1c to
720a3ed
Compare
|
@chihuahua PTAL—maybe you missed this one? (You approved PR494 and PR495, but they depend on this.) |
teamdandelion
approved these changes
Sep 11, 2017
|
@dandelionmane thanks! |
|
This looks great. Thanks, William! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This commit replaces uses like
base + "?things"(whenbaseis notknown to not already contain a query component), or that fail to call
encodeURIComponenton thethings, with uses ofaddParams.I generated this commit by running
git grep '[&?].*='andinvestigating each occurrence. I ignored all occurrences in the graph
and projector plugins, as they have their own mini-ecosystems. I also
ignored the unique occurrence in the profile plugin, because (a) I can’t
test it, and (b) its inputs are hard-coded such that this change
provably would not fix any bugs.
Test Plan:
I verified the behavior of all existing plugins.
wchargin-branch: use-add-params