color grouping: add group by regex under feature flag #5117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psybuzz
approved these changes
Jul 9, 2021
| (onGroupByChange)="onGroupByChange($event)" | ||
| ></runs-group-menu-button-component> | ||
| `, | ||
| changeDetection: ChangeDetectionStrategy.OnPush, | ||
| }) | ||
| export class RunsGroupMenuButtonContainer { | ||
| showGroupByRegex$?: Observable<boolean> = this.store.select( |
There was a problem hiding this comment.
Can the '?' be dropped, since this field is initialized and never set to null/undefined?
There was a problem hiding this comment.
ah you're right. thanks for catching this. removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
We want to bring up color group by regex gradually by adding a feature flag
enableColorGroupByRegexThe feature flag is added in global (also shown in OSS) and we want to flip the flag in tb.corp only later (no concrete plan to bring color grouping in OSS yet)
Technical description of changes
Screenshots of UI changes
with
?enableColorGroupByRegex=truewe can see third item on the dropdown. Click it should emit;