Remove the hatched background from functions #601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the graph explorer had made functions stand out via giving them a hatched background. However, functions are intended to seamlessly integrate into the graph, so remove the hatch. @wchargin brought up some good points. * The nodes are extremely hard to read. To quote from pgfmanual (3.0.1a, 95): Do not use background patterns, like a crosshatch or diagonal lines, instead of colors. They distract. Background patterns in information graphics are _evil_. * We already have a "Usages of the Function" section within the info card that shows up when either a function template or one of its calls is selected. This suffices to identify the node as being associated with a function. * We already have triangles within function nodes that uniquely identify function input and output ops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the graph explorer had made functions stand out via giving
them a hatched background. However, functions are intended to seamlessly
integrate into the graph, so we remove the hatch. @wchargin brought up some
compelling points:
95): Do not use background patterns, like a crosshatch or diagonal
lines, instead of colors. They distract. Background patterns in
information graphics are evil.
card that shows up when either a function template or one of its calls
is selected. This suffices to identify the node as being associated with
a function.
function input and output ops.
Test Plan: Start TensorBoard pointed at the attached events file. Note that
function nodes now lack hatched backgrounds.
events.out.tfevents.1506397086.functions.txt