Refactor: Handle Smoothed column logic in DataTable #6094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHollyer
force-pushed
the
MoveSmoothedLogic
branch
from
0d29898 to
6d99ce7
Compare
rileyajones
approved these changes
Dec 7, 2022
qihach64
pushed a commit
to qihach64/tensorboard
that referenced
this pull request
Dec 19, 2022
* Motivation for features / changes The smoothed column in the scalar card data table does not render when smoothing is disabled. The logic for removing this column previously occurred in the ScalarCardContainer where it removed the column entirely from the list of headers. This causes some strange behavior which needs to be handled when dealing with changing the order of the columns. This change removes the special treatment of the Smoothed column everywhere except for when it is rendered. * Screenshots of UI changes No changes.
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
* Motivation for features / changes The smoothed column in the scalar card data table does not render when smoothing is disabled. The logic for removing this column previously occurred in the ScalarCardContainer where it removed the column entirely from the list of headers. This causes some strange behavior which needs to be handled when dealing with changing the order of the columns. This change removes the special treatment of the Smoothed column everywhere except for when it is rendered. * Screenshots of UI changes No changes.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
* Motivation for features / changes The smoothed column in the scalar card data table does not render when smoothing is disabled. The logic for removing this column previously occurred in the ScalarCardContainer where it removed the column entirely from the list of headers. This causes some strange behavior which needs to be handled when dealing with changing the order of the columns. This change removes the special treatment of the Smoothed column everywhere except for when it is rendered. * Screenshots of UI changes No changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The smoothed column in the scalar card data table does not render when smoothing is disabled. The logic for removing this column previously occurred in the ScalarCardContainer where it removed the column entirely from the list of headers. This causes some strange behavior which needs to be handled when dealing with changing the order of the columns.
This change removes the special treatment of the Smoothed column everywhere except for when it is rendered.
No changes.