Refactor AuthContext creation into standalone AuthContextMiddleware. #6131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcra
approved these changes
Jan 5, 2023
| def _create_auth_provider_verifier_app(expected_auth_key): | ||
| """Generates a WSGI application for verifying AuthContextMiddleware. | ||
|
|
||
| It should be placed downstream from the AuthContextMiddleware. It will |
There was a problem hiding this comment.
nit: I wasn't sure of what this "downstream" terminology meant. For some reason I was imagining the opposite of what you're doing in the test below, although perhaps that doesn't make much sense.
This is just for this test/file, so it doesn't matter much, but consider whether a different phrasing or a 2-line example would be worth adding.
There was a problem hiding this comment.
I just tried to reword since adding an example just duplicates the code below. Since the WSGI PEP (https://peps.python.org/pep-0333/) makes a passing reference to the "Chain of Responsibility" pattern, I reworded in those terms.
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
…ensorflow#6131) The TensorBoard application layer creates a middleware that injects AuthContext into the RequestContext. It would be useful to expose this middleware for other usage - there are at least a couple test files in the internal code base that could make use of it. This change refactors the middleware into its own file for reuse, naming it AuthContextMiddleware and giving it its own devoted test.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
…ensorflow#6131) The TensorBoard application layer creates a middleware that injects AuthContext into the RequestContext. It would be useful to expose this middleware for other usage - there are at least a couple test files in the internal code base that could make use of it. This change refactors the middleware into its own file for reuse, naming it AuthContextMiddleware and giving it its own devoted test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TensorBoard application layer creates a middleware that injects AuthContext into the RequestContext. It would be useful to expose this middleware for other usage - there are at least a couple test files in the internal code base that could make use of it.
This change refactors the middleware into its own file for reuse, naming it AuthContextMiddleware and giving it its own devoted test.