Skip to content

TensorBoard 2.12.1 #6282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 31, 2023
Merged

TensorBoard 2.12.1 #6282

merged 5 commits into from
Mar 31, 2023

Conversation

arcra
Copy link
Member

@arcra arcra commented Mar 31, 2023

  • Motivation for features / changes

    A patch release that bumps our restriction on the google-auth-oauthlib dependency to be compatible with newer versions. Now that we removed the deprecated OOB auth flow (Implements limited-input device auth flow, to replace deprecated OOB auth flow. #6107), we can use a newer version of the library where that flow is removed, and TB will be compatible with more libraries that have similar restrictions for a more recent version of the auth library.

  • Technical description of changes

  • Detailed steps to verify changes work correctly (as executed by you)

    Revoked saved credentials by calling tensorboard dev auth revoke, and then uploaded a new experiment to TB.dev, which required me to go through the auth flow. Then I repeated the same process with the flag --auth_force_console to test the "console" (limited-input device) auth flow. Both auth flows worked as expected, and I was able to upload data for those experiments.

@arcra arcra requested a review from groszewn March 31, 2023 01:54
Copy link
Contributor

@groszewn groszewn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! The CI issue for lint-rust should be sorted out shortly, you can rerun CI once #6283 is merged.

arcra added 5 commits March 31, 2023 21:15
…l with dependencies specified by Cargo.lock files of the installed package.
…rsion 1.0 (tensorflow#6246)

* Motivation for features / changes
As requested and noted in tensorflow#6197, we can bump this restriction, which is
currently affecting compatibility of TB with dependency requirements
from other packages. After the OOB auth flow migration, this should be
possible.

* Technical description of changes
Just bump the restriction for `google-auth-oauthlib` in our
`requirements.txt` file, to support newer versions.

* Detailed steps to verify changes work correctly (as executed by you)
Executed the auth flows (both the console-only one, and the one that
uses a browser in the same machine), and validated that they work as
before with the newer version.
@arcra arcra merged commit e03778d into tensorflow:2.12 Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants