-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add delete column button on data table #6410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
japie1235813
merged 13 commits into
tensorflow:master
from
bhuang1323:delete-button-data-table
Jun 12, 2023
Merged
Add delete column button on data table #6410
japie1235813
merged 13 commits into
tensorflow:master
from
bhuang1323:delete-button-data-table
Jun 12, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japie1235813
reviewed
Jun 5, 2023
tensorboard/webapp/widgets/data_table/data_table_component.scss
Outdated
Show resolved
Hide resolved
tensorboard/webapp/widgets/data_table/data_table_component.ng.html
Outdated
Show resolved
Hide resolved
tensorboard/webapp/metrics/views/card_renderer/scalar_card_component.ts
Outdated
Show resolved
Hide resolved
tensorboard/webapp/metrics/views/card_renderer/scalar_card_test.ts
Outdated
Show resolved
Hide resolved
japie1235813
reviewed
Jun 6, 2023
tensorboard/webapp/metrics/views/card_renderer/scalar_card_data_table.ts
Outdated
Show resolved
Hide resolved
tensorboard/webapp/metrics/views/card_renderer/scalar_card_component.ts
Outdated
Show resolved
Hide resolved
japie1235813
reviewed
Jun 6, 2023
japie1235813
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience and making all those changes! Lgtm.
tensorboard/webapp/widgets/data_table/data_table_component.scss
Outdated
Show resolved
Hide resolved
rileyajones
reviewed
Jun 9, 2023
japie1235813
approved these changes
Jun 9, 2023
tensorboard/webapp/widgets/data_table/header_cell_component_test.ts
Outdated
Show resolved
Hide resolved
tensorboard/webapp/widgets/data_table/header_cell_component_test.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
Add ability to remove column directly from data table rather than navigating to settings panel to remove.
Technical description of changes
Added a new button on data table that uses existing column toggling functionality (from the settings panel) to disable selection column.
Screenshots of UI changes (or N/A)
video
Detailed steps to verify changes work correctly (as executed by you)
enableHparamsInTimeSeries
feature flag.Alternate designs / implementations considered (or N/A)