HParams: Add new state property to store hparam and metric filters #6553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmd3k
approved these changes
Aug 22, 2023
| export type HparamFilter = DiscreteFilter | IntervalFilter; | ||
| export type MetricFilter = IntervalFilter; | ||
|
|
||
| export interface HparamsAndMetricsFilters { |
There was a problem hiding this comment.
The only difference between this type name and the one on L32 is where you put the 'And'. That's really confusing. Can we do better?
| @@ -630,4 +630,72 @@ describe('hparams/_redux/hparams_reducers_test', () => { | |||
| expect(state2.dashboardSessionGroups).toEqual([mockSessionGroup]); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('dashboardHparamFilterAdded', () => { | |||
| it('adds entry dashboardFilters', () => { | |||
There was a problem hiding this comment.
Can we add another test that contains existing items in hparams and ensures they are not overwritten?
|
|
||
| describe('dashboardMetricFilterAdded', () => { | ||
| it('adds entry dashboardFilters', () => { | ||
| const state = buildHparamsState(); |
There was a problem hiding this comment.
Similar: Can we add another test that contains existing items in metrics and ensures they are not overwritten?
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Aug 25, 2023
…ensorflow#6553) ## Motivation for features / changes Now that the filter dialog is merged tensorflow#6493 we need to add support for filtering by hparams. However, tensorflow#6544 changed the way hparam values are read. This change adds a new property to state in which to store dashboard related hparam and metric filters. See tensorflow#6488 for the WIP integration with the runs_table_container + tb_data_table -> common_selectors + hparam_selectors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
Now that the filter dialog is merged #6493 we need to add support for filtering by hparams. However, #6544 changed the way hparam values are read. This change adds a new property to state in which to store dashboard related hparam and metric filters.
See #6488 for the WIP integration with the runs_table_container + tb_data_table -> common_selectors + hparam_selectors.