Skip to content

HParams: Enable hparamsInTimeSeries by default #6565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2023
Merged

HParams: Enable hparamsInTimeSeries by default #6565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4a2bfa
enable hparams in timeseries by default
rileyajones Sep 1, 2023
3cd4ce2
Update tests
rileyajones Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tensorboard/webapp/feature_flag/store/feature_flag_metadata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ export const FeatureFlagMetadataMap: FeatureFlagMetadataMapType<FeatureFlags> =
parseValue: parseBoolean,
},
enableHparamsInTimeSeries: {
defaultValue: false,
defaultValue: true,
queryParamOverride: 'enableHparamsInTimeSeries',
parseValue: parseBoolean,
},
Expand Down
1 change: 1 addition & 0 deletions tensorboard/webapp/runs/effects/runs_effects_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ describe('runs_effects', () => {
});
store.overrideSelector(getExperimentIdsFromRoute, null);
store.overrideSelector(getActiveRoute, buildRoute());
store.overrideSelector(getEnableHparamsInTimeSeries, false);
});

afterEach(() => {
Expand Down
6 changes: 3 additions & 3 deletions tensorboard/webapp/runs/views/runs_table/runs_data_table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,16 +111,16 @@ export class RunsDataTable {
}

allRowsSelected() {
return this.data.every((row) => row['selected']);
return this.data?.every((row) => row['selected']);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should never be undefined or null as long as the store exists, however, we have a funky test in tensorboard/webapp/metrics/metrics_integration_test.ts which checks the state of the app if the store is not defined.

}

someRowsSelected() {
return this.data.some((row) => row['selected']);
return this.data?.some((row) => row['selected']);
}

handleSelectAll(event: MouseEvent) {
event.preventDefault();
this.onAllSelectionToggle.emit(this.data.map((row) => row.id));
this.onAllSelectionToggle.emit(this.data?.map((row) => row.id));
}

onFilterKeyUp(event: KeyboardEvent) {
Expand Down