MDCMigration: Restyle the header tabs #6606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHollyer
approved these changes
Sep 28, 2023
bmd3k
added a commit
to bmd3k/tensorboard
that referenced
this pull request
Oct 2, 2023
This reverts commit bdd7eaa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
Background: We are trying to migrate to all the non legacy angular components. To accomplish this we changed them all over at once and began hunting for differences.
One of the biggest differences is that the header is totally foobar. This seems to be primarily due to the following issues:
mat-tabcomponent had a significant number of structural changesScreenshots of UI changes (or N/A)
Before
After
With Restyling
Googlers
Light Mode https://screenshot.googleplex.com/AJdQE3T35aQSxpT
Dark Mode https://screenshot.googleplex.com/4Tn3XYqd6FSKCzS