Bug Fix: Allow icons to be sized by both width and height #6709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmd3k
requested changes
Dec 27, 2023
| .mat-mdc-button-touch-target { | ||
| height: 100%; | ||
| width: 100%; | ||
| ::ng-deep :not(mat-calendar) { |
There was a problem hiding this comment.
I think this breaks button styling across the entire app.
There was a problem hiding this comment.
I have come up with an entirely new approach to this which should resolve this issue
rileyajones
force-pushed
the
calendar-icon
branch
from
5f6b8a5 to
3f89dd0
Compare
rileyajones
changed the title
mat-calendar icons
bmd3k
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
During the mdc-migration I restyled all the buttons via #6608 and only recently noticed that the
mat-calendarcomponent (which is only used internally) looked pretty off...To resolve this I am allowing button widths and heights to be set separately then overriding them in the internal date picker component (Googlers see cl/601592566).
Screenshots of UI changes (or N/A)
Before - https://screenshot.googleplex.com/AKuAQqzf9g6K2GF
After - https://screenshot.googleplex.com/7s6vm8SsajKg9v7