[Debugger Plugin]: Add clickable links to Session.runs table #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chihuahua
approved these changes
Dec 11, 2017
| .sidebar { | ||
| position: relative; | ||
| height: 100%; | ||
| /* width: 40%; */ |
There was a problem hiding this comment.
We can probably just delete these commented lines.
| return((graphElementName) => { | ||
| let nodeName = graphElementName; | ||
| // If it is a tensor name, get the node name. | ||
| if (nodeName.indexOf(':') !== -1) { |
There was a problem hiding this comment.
Optional: Maybe compute once and reuse value.
There was a problem hiding this comment.
This computation is pretty cheap. So I'd rather save the space.
|
|
||
| .node-or-tensor-element { | ||
| text-decoration: underline; | ||
| cursor: pointer; |
There was a problem hiding this comment.
Optional: Add a .node-or-tensor-element:hover effect to emphasize how an item is clickable.
There was a problem hiding this comment.
Good suggestion. I did this for all clickable elements currently present in the Debugger Plugin.
Clicking a node or tensor in the table focuses on the corresponding node in the graph visualizer, if it exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking a node or tensor in the table focuses on the corresponding node
in the graph visualizer, if it exists.