Only open first two panes by default #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chihuahua
approved these changes
Jan 12, 2018
| @@ -160,6 +160,10 @@ <h3>No audio data was found.</h3> | |||
| }); | |||
| }, | |||
|
|
|||
| _shouldOpen(index) { | |||
| return index <= 2; | |||
There was a problem hiding this comment.
nit: I think this should be 1, right?
There was a problem hiding this comment.
Surprisingly enough, the indexes appear to start at 1.
There was a problem hiding this comment.
The indexes actually start at 0: https://stackoverflow.com/questions/31388072/polymer-1-0-dom-repeat-display-index-starting-at-1
The reason that <= 2 works is because the 0th pane is the search pane, apparently:
https://github.com/tensorflow/tensorboard/blob/master/tensorboard/components/tf_categorization_utils/categorizationUtils.ts#L104
| @@ -245,6 +245,10 @@ <h3>No scalar data was found.</h3> | |||
| return _smoothingWeight > 0; | |||
| }, | |||
|
|
|||
| _shouldOpen(index) { | |||
There was a problem hiding this comment.
Should we also update tf-pr-curve-dashboard.html and tf-text-dashboard.html?
This will prevent TensorBoard from using too many resources for anyone with a large number of tags. In the near future we might want to solve this in a smarter way, possibly by not rendering things outside the viewport. See also tensorflow#728
jart
force-pushed
the
close-the-pod-bay-doors-hal
branch
from
a5dcd48 to
9d1567a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent TensorBoard from using too many resources for anyone with a
large number of tags. In the near future we might want to solve this in a
smarter way, possibly by not rendering things outside the viewport.
See also #728