Fix graph minimap by removing CSS property #899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, the graph explorer minimap had been broken, as discovered by @nfelt during manual testing. Specifically, the graph would not render within the minimap. Surprisingly, this CSS specification within the `tf-debugger-initial-dialog` component had been hiding the SVG element for the rendered graph within the minimap: ```css :host:not([_open]) { display: none; } ``` That seems odd. The `:host` selector refers to the root of the shadow DOM for the current component, in this case `tf-debugger-initial-dialog`. That dialog is only rendered by the debugger plugin - the debugger dashboard is not even constructed when the graph dashboard (containing the minimap) is rendered. I perused the vulcanized HTML and JS, and no issues seem to stand out there. This change solves the immediate problem of the minimap not rendering by making the selector more specific and apply only to the component. I will later investigate what is causing a CSS specification within the `tf-debugger-initial-dialog` component to affect the graph explorer minimap.
jart
approved these changes
Jan 23, 2018
nfelt
pushed a commit
to nfelt/tensorboard
that referenced
this pull request
Feb 7, 2018
Before this change, the graph explorer minimap had been broken, as discovered by @nfelt during manual testing. Specifically, the graph would not render within the minimap. Surprisingly, this CSS specification within the `tf-debugger-initial-dialog` component had been hiding the SVG element for the rendered graph within the minimap: ```css :host:not([_open]) { display: none; } ``` That seems odd. The `:host` selector refers to the root of the shadow DOM for the current component, in this case `tf-debugger-initial-dialog`. That dialog is only rendered by the debugger plugin - the debugger dashboard is not even constructed when the graph dashboard (containing the minimap) is rendered. I perused the vulcanized HTML and JS, and no issues seem to stand out there. This change solves the immediate problem of the minimap not rendering by making the selector more specific and apply only to the component. I will later investigate what is causing a CSS specification within the `tf-debugger-initial-dialog` component to affect the graph explorer minimap.
nfelt
pushed a commit
that referenced
this pull request
Feb 7, 2018
Before this change, the graph explorer minimap had been broken, as discovered by @nfelt during manual testing. Specifically, the graph would not render within the minimap. Surprisingly, this CSS specification within the `tf-debugger-initial-dialog` component had been hiding the SVG element for the rendered graph within the minimap: ```css :host:not([_open]) { display: none; } ``` That seems odd. The `:host` selector refers to the root of the shadow DOM for the current component, in this case `tf-debugger-initial-dialog`. That dialog is only rendered by the debugger plugin - the debugger dashboard is not even constructed when the graph dashboard (containing the minimap) is rendered. I perused the vulcanized HTML and JS, and no issues seem to stand out there. This change solves the immediate problem of the minimap not rendering by making the selector more specific and apply only to the component. I will later investigate what is causing a CSS specification within the `tf-debugger-initial-dialog` component to affect the graph explorer minimap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the graph explorer minimap had been broken, as
discovered by @nfelt during manual testing. Specifically, the graph
would not render within the minimap.
Surprisingly, this CSS specification within the
tf-debugger-initial-dialogcomponent had been hiding the SVG elementfor the rendered graph within the minimap:
That seems odd. The
:hostselector refers to the root of the shadowDOM for the current component, in this case
tf-debugger-initial-dialog. That dialog is only rendered by thedebugger plugin - the debugger dashboard is not even constructed when
the graph dashboard (containing the minimap) is rendered.
I perused the vulcanized HTML and JS, and no issues seem to stand out
there.
This change solves the immediate problem of the minimap not rendering by
making the selector more specific and apply only to the component. I
will later investigate what is causing a CSS specification within the
tf-debugger-initial-dialogcomponent to affect the graph explorerminimap.
The minimap now renders:
The dialog (within the debugger dashboard) still renders as expected:
The dialog still hides as expected: