Skip to content

remove testing dependency on jasmine_util and update dependencies #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 24, 2020

Conversation

tafsiri
Copy link
Contributor

@tafsiri tafsiri commented Oct 23, 2020

This removes dist imports from tjfs-core.

Updates the following examples to tfjs 2.6.0:
abalone-node, date-conversion-attention, fashion-mnist-vae, jena-weather, lstm-text-generation, mnist-acgan, snake-dqn

jena-weather also had a code update to match the current tfjs-data api.
Updating sentiment turned up a bug that may be an issue in core. So I'll look at that separately and update once there is a diagnosis/fix.

This change is Reviewable

@tafsiri tafsiri changed the title remove dependency on jasmine_util from core remove testing dependency on jasmine_util Oct 23, 2020
@tafsiri tafsiri changed the title remove testing dependency on jasmine_util remove testing dependency on jasmine_util and update dependencies Oct 23, 2020
@tafsiri tafsiri marked this pull request as ready for review October 23, 2020 17:48
@tafsiri tafsiri requested review from caisq and bileschi October 23, 2020 17:48
Copy link
Collaborator

@caisq caisq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @tafsiri !

@caisq caisq merged commit a3a1790 into master Oct 24, 2020
@mihaimaruseac mihaimaruseac deleted the remove-jasmine-util branch December 16, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants