-
Notifications
You must be signed in to change notification settings - Fork 31
fix: Make styles compatible with Joplin 3.1.22 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: Make styles compatible with Joplin 3.1.22 #1
Conversation
Oh, wow. Thanks. Yep, I've also noticed that the CSS requires tweaking for CM6, so thanks for adding the classes. The last few weeks have been crazy. Still dealing with the aftermath of a break-in. So this certainly helps a lot. |
Thank you for testing it! So far, I've only tried this pull request with Joplin 3.1.22 (and only the |
Thank you for including a screenshot! The different editor styles seem to match cases where the CSS file references classes generated by CodeMirror's classHighlighter extension (the elements with If the
If the Additional notes:
That should be fixed by 0b189ce! |
Summary
This pull request adjusts
userchrome.css
for compatibility with Joplin 3.1.22. This does not adjustuserstyle.css
.Note
Many of the changes are related to the upgrade from CodeMirror v5 to v6. CodeMirror 6-specific styles have been marked with
/* CM6 */
comments.Important
This pull request is currently a draft — it needs more manual testing and potentially refactoring.
Screenshot (
userchrome.css
only)