[suppression test] service link & no beta & has breakingchange & has suppression #3240

JackTn · 2024-03-14T07:46:54Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app-test · 2024-03-14T07:46:58Z

Next Steps to merge

Next steps that must be taken to merge this PR:

❌ Your PR is in purview of ARM review (label: ARMReview). Please ensure your PR is on the ARM PR review queue - see instructions in steps 1 and 2 in the PR description diagram.
❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it. In addition, refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app-test · 2024-03-14T07:46:59Z

Swagger Generation Artifacts

️🔄~[NotRequired_Staging] ApiDocPreview inProgress [Detail]

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from 7152bc4e23e620081526426f3eaceeceaa2fab38. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mCannot find path�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m�[31;1m�[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m�[31;1m�[36;1m�[31;1m�[36;1m     | �[31;1mit does not exist.�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact�[0m
error	Fatal error: Cannot read properties of undefined (reading 'sort')
Cannot read properties of undefined (reading 'sort')
error	Fatal error: TypeError: Cannot read properties of undefined (reading 'sort')    at diffStringArrays (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/utils/utils.js:11:11)    at getSuppressionLines (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/utils/handleSuppressionLines.js:28:51)    at getPackageData (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/types/PackageData.js:68:113)    at /mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:242:191    at Array.map (<anonymous>)    at workflowHandleReadmeMdOrTypeSpecProject (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:242:142)    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)    at async workflowMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:107:9)    at async sdkAutoMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:215:13)    at async /mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18
error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from 7152bc4e23e620081526426f3eaceeceaa2fab38. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-servicelinker [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Removed operation LinkerOperations.list
info	[Changelog]   - Removed operation group Operations

Present SDK breaking changes suppressions
Removed operation LinkerOperations.begin_create_or_update
Removed operation LinkerOperations.list
Removed operation LinkerOperations.list
Removed operation group Operations

Please refer to https://aka.ms/azsdk/sdk-suppression for more information.

️❌ azure-sdk-for-java failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from 7152bc4e23e620081526426f3eaceeceaa2fab38. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] rd  Average Speed   Time    Time     Time  Current
cmderr	[init.sh]                                  Dload  Upload   Total   Spent    Left  Speed
cmderr	[init.sh] 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0-:-- --:--:--  675k
cmderr	[init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz...
cmderr	[init.sh] Computing checksum with sha256sum
cmderr	[init.sh] Checksums matched!
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
error	Fatal error: Cannot read properties of undefined (reading 'sort')
Cannot read properties of undefined (reading 'sort')
error	Fatal error: TypeError: Cannot read properties of undefined (reading 'sort')    at diffStringArrays (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/utils/utils.js:11:11)    at getSuppressionLines (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/utils/handleSuppressionLines.js:28:51)    at getPackageData (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/types/PackageData.js:68:113)    at /mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:242:191    at Array.map (<anonymous>)    at workflowHandleReadmeMdOrTypeSpecProject (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:242:142)    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)    at async workflowMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:111:13)    at async sdkAutoMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:215:13)    at async /mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 7152bc4e23e620081526426f3eaceeceaa2fab38. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/servicelinker/armservicelinker [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Enum `ActionType` has been removed
info	[Changelog] - Enum `Origin` has been removed
info	[Changelog] - Function `*ClientFactory.NewOperationsClient` has been removed
info	[Changelog] - Function `*LinkerClient.NewListPager` has been removed
info	[Changelog] - Function `NewOperationsClient` has been removed
info	[Changelog] - Function `*OperationsClient.NewListPager` has been removed
info	[Changelog] - Struct `Operation` has been removed
info	[Changelog] - Struct `OperationDisplay` has been removed
info	[Changelog] - Struct `OperationListResult` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `ClientTypeKafkaSpringBoot` added to enum type `ClientType`
info	[Changelog]
info	[Changelog] Total 12 breaking change(s), 1 additive change(s).

Present SDK breaking changes suppressions
Enum `ActionType` has been removed
Enum `Origin` has been removed
Function `*ClientFactory.NewOperationsClient` has been removed
Function `*LinkerClient.NewListPager` has been removed
Function `*OperationsClient.NewListPager` has been removed
Function `NewOperationsClient` has been removed
Struct `OperationDisplay` has been removed
Struct `OperationListResult` has been removed
Struct `Operation` has been removed

Please refer to https://aka.ms/azsdk/sdk-suppression for more information.

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 7152bc4e23e620081526426f3eaceeceaa2fab38. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-servicelinker [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-servicelinker-3.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Enum KnownClientType has a new value KafkaSpringBoot
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Removed operation group Operations
info	[Changelog]   - Removed operation Linker.list
info	[Changelog]   - Class ServiceLinkerManagementClient no longer has parameter operations
info	[Changelog]   - Removed Enum KnownActionType
info	[Changelog]   - Removed Enum KnownOrigin
info	[Changelog]   - Removed function getContinuationToken

Present SDK breaking changes suppressions
Class ServiceLinkerManagementClient no longer has parameter operations
Removed Enum KnownActionType
Removed Enum KnownOrigin
Removed function getContinuationToken
Removed operation Linker.beginCreateOrUpdate
Removed operation Linker.beginCreateOrUpdateAndWait
Removed operation Linker.list
Removed operation group Operations

Please refer to https://aka.ms/azsdk/sdk-suppression for more information.

️🔄 azure-resource-manager-schemas inProgress [Detail]

️🔄 azure-powershell inProgress [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app-test · 2024-03-14T07:46:59Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/servicelinker/armservicelinker	Create ApiView failed. To get help, please see [aka.ms/azsdk/pr-getting-help](https://aka.ms/azsdk/pr-getting-help).
JavaScript	@azure/arm-servicelinker	Create ApiView failed. To get help, please see [aka.ms/azsdk/pr-getting-help](https://aka.ms/azsdk/pr-getting-help).
Swagger	Microsoft.ServiceLinker	Create ApiView failed. To get help, please see [aka.ms/azsdk/pr-getting-help](https://aka.ms/azsdk/pr-getting-help).

openapi-pipeline-app-test · 2024-03-14T07:47:00Z

Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]

Compared specs (v0.10.5)	new version	base version
servicelinker.json	2022-05-01(3e7b7f3)	2022-05-01(main)

Rule	Message
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/{resourceUri}/providers/Microsoft.ServiceLinker/linkers' removed or restructured? Old: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L37:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.ServiceLinker/operations' removed or restructured? Old: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L354:5

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️❌LintDiff: 1 Errors, 0 Warnings failed [Detail]

Compared specs (v2.2.0)	new version	base version
package-2022-05-01	package-2022-05-01(3e7b7f3)	package-2022-05-01(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
`❌` OperationsAPIImplementation	Operations API must be implemented for 'Microsoft.ServiceLinker'. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L1

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'linkerName' should be defined with a 'pattern' restriction. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L37
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L131
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L164
`❌` PatchResponseCodes	Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L175
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:type. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L205
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:authType. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L205
`❌` LroPatch202	The async patch operation should return 202. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L210
`❌` ResourceNameRestriction	The resource name parameter 'linkerName' should be defined with a 'pattern' restriction. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L232
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L266
`❌` ResourceNameRestriction	The resource name parameter 'linkerName' should be defined with a 'pattern' restriction. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L278
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L51
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L67
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L95
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L126
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L151
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L170
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L195
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L226
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'validatelinker' in:'Linker_Validate'. Consider updating the operationId Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L237
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L253
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L272
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L295
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L311
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L402
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L669
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L685
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L837

️️✔️~[NotRequired_Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️❌Avocado: 2 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` UNREFERENCED_JSON_FILE	The example JSON file is not referenced from the swagger file. readme: specification/servicelinker/resource-manager/readme.md json: stable/2022-05-01/examples/LinkList.json
`❌` UNREFERENCED_JSON_FILE	The example JSON file is not referenced from the swagger file. readme: specification/servicelinker/resource-manager/readme.md json: stable/2022-05-01/examples/OperationsList.json

️❌ModelValidation: 4 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L664:23 ExampleUrl: stable/2022-05-01/examples/PutLink.json#L25:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L664:23 ExampleUrl: stable/2022-05-01/examples/PutLink.json#L41:15
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L157:22 ExampleUrl: stable/2022-05-01/examples/DeleteLink.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L259:22 ExampleUrl: stable/2022-05-01/examples/ValidateLinkSuccess.json

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️~[NotRequired_Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️PR Summary succeeded [Detail] [Expand]

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

workflow-bot-test · 2024-03-14T07:52:47Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

JackTn · 2024-03-15T03:20:22Z

/azp run

azure-pipelines · 2024-03-15T03:20:29Z

Azure Pipelines successfully started running 1 pipeline(s).

JackTn · 2024-03-18T07:38:59Z

/azp run

azure-pipelines · 2024-03-18T07:39:07Z

Azure Pipelines successfully started running 1 pipeline(s).

JackTn · 2024-03-19T03:10:14Z

/azp run

azure-pipelines · 2024-03-19T03:10:22Z

Azure Pipelines successfully started running 1 pipeline(s).

JackTn and others added 2 commits March 8, 2024 10:47

change specificationRepositoryConfiguration.json to support test env

f82646f

add

895031b

azure-sdk mentioned this pull request Mar 14, 2024

[AutoPR sdk/resourcemanager/servicelinker/armservicelinker] [suppression test] service link & no beta & has breakingchange & has suppression azure-sdk/azure-sdk-for-go#9255

Closed

azure-sdk added the BreakingChange-Go-Sdk label Mar 14, 2024

AzureRestAPISpecReview added ARMChangesRequested ARMReview BreakingChangeReviewRequired resource-manager RPaaS labels Mar 14, 2024

azure-sdk added the BreakingChange-Python-Sdk label Mar 14, 2024

azure-sdk added the BreakingChange-JavaScript-Sdk label Mar 14, 2024

Rename sdk-suppression.yml to sdk-suppressions.yml

cc56e2c

openapi-pipeline-app-test bot added BreakingChange-Go-Sdk-Suppression BreakingChange-JavaScript-Sdk-Suppression BreakingChange-Python-Track2-Sdk-Suppression labels Mar 14, 2024

change suppression

6f6d07d

JackTn added Approved-BreakingChange BreakingChange-Approved-Benign ARMSignedOff labels Mar 15, 2024

rename suppression file name

4672528

JackTn added 2 commits March 18, 2024 16:18

fix suppression file

2c96c70

fix bug

f84b58c

openapi-pipeline-app-test bot removed BreakingChange-Go-Sdk-Suppression BreakingChange-JavaScript-Sdk-Suppression labels Mar 18, 2024

fix bug

59ac667

openapi-pipeline-app-test bot added BreakingChange-Go-Sdk-Suppression BreakingChange-JavaScript-Sdk-Suppression BreakingChange-Python-Sdk-Suppression labels Mar 18, 2024

azure-sdk removed the BreakingChange-Python-Sdk label Mar 18, 2024

fix bug

4241784

openapi-pipeline-app-test bot removed BreakingChange-Go-Sdk-Suppression BreakingChange-JavaScript-Sdk-Suppression BreakingChange-Python-Sdk-Suppression labels Mar 18, 2024

azure-sdk added the BreakingChange-Python-Sdk label Mar 18, 2024

fix bug

3e7b7f3

openapi-pipeline-app-test bot added BreakingChange-Go-Sdk-Suppression BreakingChange-JavaScript-Sdk-Suppression BreakingChange-Python-Sdk-Suppression labels Mar 18, 2024

azure-sdk removed BreakingChange-Python-Sdk BreakingChange-JavaScript-Sdk labels Mar 18, 2024

azure-sdk removed the BreakingChange-Go-Sdk label Mar 19, 2024

konrad-jamrozik removed the Approved-BreakingChange label Apr 8, 2024

konrad-jamrozik force-pushed the main branch from eb5d86e to 5bc43b0 Compare April 9, 2024 18:48

JackTn closed this Oct 25, 2024

JackTn deleted the jacktn/test-rpservice-2 branch October 25, 2024 06:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[suppression test] service link & no beta & has breakingchange & has suppression #3240

[suppression test] service link & no beta & has breakingchange & has suppression #3240

JackTn commented Mar 14, 2024 •

edited by workflow-bot-test bot

Loading

openapi-pipeline-app-test bot commented Mar 14, 2024 •

edited

Loading

openapi-pipeline-app-test bot commented Mar 14, 2024 •

edited

Loading

openapi-pipeline-app-test bot commented Mar 14, 2024 •

edited

Loading

openapi-pipeline-app-test bot commented Mar 14, 2024 •

edited

Loading

workflow-bot-test bot commented Mar 14, 2024

JackTn commented Mar 15, 2024

azure-pipelines bot commented Mar 15, 2024

JackTn commented Mar 18, 2024

azure-pipelines bot commented Mar 18, 2024

JackTn commented Mar 19, 2024

azure-pipelines bot commented Mar 19, 2024

[suppression test] service link & no beta & has breakingchange & has suppression #3240

[suppression test] service link & no beta & has breakingchange & has suppression #3240

Conversation

JackTn commented Mar 14, 2024 • edited by workflow-bot-test bot Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Diagram footnotes

Purpose of this PR

Due diligence checklist

Additional information

Getting help

openapi-pipeline-app-test bot commented Mar 14, 2024 • edited Loading

Next Steps to merge

openapi-pipeline-app-test bot commented Mar 14, 2024 • edited Loading

Swagger Generation Artifacts

openapi-pipeline-app-test bot commented Mar 14, 2024 • edited Loading

Generated ApiView

openapi-pipeline-app-test bot commented Mar 14, 2024 • edited Loading

Swagger Validation Report

workflow-bot-test bot commented Mar 14, 2024

JackTn commented Mar 15, 2024

azure-pipelines bot commented Mar 15, 2024

JackTn commented Mar 18, 2024

azure-pipelines bot commented Mar 18, 2024

JackTn commented Mar 19, 2024

azure-pipelines bot commented Mar 19, 2024

JackTn commented Mar 14, 2024 •

edited by workflow-bot-test bot

Loading

openapi-pipeline-app-test bot commented Mar 14, 2024 •

edited

Loading

openapi-pipeline-app-test bot commented Mar 14, 2024 •

edited

Loading

openapi-pipeline-app-test bot commented Mar 14, 2024 •

edited

Loading

openapi-pipeline-app-test bot commented Mar 14, 2024 •

edited

Loading