Skip to content

Make junit dependency test scope #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make junit dependency test scope #1718

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 7, 2019

The junit dependency was in compile scope and should be in test scope.

@ghost ghost requested review from bsideup, kiview and rnorth as code owners August 7, 2019 12:55
@ghost
Copy link
Author

ghost commented Aug 7, 2019

oops. I think I understand it now.

@ghost ghost closed this Aug 7, 2019
@ghost ghost deleted the patch-1 branch August 7, 2019 12:59
@astubbs
Copy link

astubbs commented Dec 6, 2019

Can you elaborate as to why it's marked as a compile dep?
This is causing me some problems. I use jupiter (junit 5).

It was added in this PR: #574 In commit: fe62ccf

@bsideup
Copy link
Member

bsideup commented Dec 6, 2019

It was added... with the very first commit :D

Every type in Testcontainers extends from JUnit 4 types because, back then when Testcontainers was created, JUnit 5 did not exist, and integrating with JUnit 4 made it very easy to adopt the library for many.

Testcontainers 2.0 will be refactored to remove the dependency on JUnit 4:
#970

@astubbs
Copy link

astubbs commented Dec 6, 2019

I see :/ I suspect this combination may be causing my surefire to crash..

@bsideup
Copy link
Member

bsideup commented Dec 6, 2019

Never caused a problem to other surefire users, so I would suggest double checking your config

@astubbs
Copy link

astubbs commented Dec 6, 2019

Ah, nope. Sorry - it was this project I'm using for Guice Jupiter adapter: JeffFaer/junit5-extensions#7

Good old bloody git bisect run is so amazing. Then a bit of deep deep tree comparison with and without that dep added. Looks like it pulls in an older version of the common api...

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants