Offer help to maintain the repo

[KerstenBreuer]

Hi @SergeyPirogov,

I am working as a developer at the German Cancer Research Center (DKFZ) in Heidelberg and I absolutely love your testcontainers-python package. I am using it all the time at work and it makes my life way easier.

I noticed that the PRs in the repo are starting to pile up and that tests are failing. I completely understand that maintaining an open source poject that popular can be very challenging and I was wondering if you would need any help on maintaining it? I would be happy to volunteer and perform review, look at issues, etc..

If you like please contact me at any time via [email protected] (or just comment here as you wish).

Looking forward to hearing back from you.

Thanks a lot and best wishes,
Kersten

(P.S. I have a PR open to add RabbitMQ - #168. Would be great if you could approve the workflow execution and have a look.)

[callamd]

I think bringing in additional maintainers for this project would be a good step. I think it's a good project, it's definitely very useful for integration testing and is really the only option to write pythonic integration tests that I know of. I think adding to the team of maintainers would enhance the popularity of the project, which seems to be lacking the user base of the other language implementations.

[tillahoffmann]

Hey, yes, expanding the set of people who can contribute directly and maintain the code base is a good idea. I'm happy to add @KerstenBreuer unless you have objections @SergeyPirogov.

[SergeyPirogov]

I dont see many requests for changes

[tillahoffmann]

I think there's a bit of stuff we could do in terms of maintenance (I've closed a few outstanding issues that were resolved/didn't have a response). Maybe this thread is an opportunity to prioritise.

Maintenance and bugs

• google cloud pubsub container do not expects keyword argument "channel" for publisher and subscriber client #161 raises issues with google cloud pubsub (presumably because the python client version used in our repo hasn't been bumped in a while).
• Docker in Docker on Mac requires to use host.docker.internal #159, Initial port check fails with "object is not subscriptable" #157, Testcontainers fails to get container_host_ip when running in docker network #141, Let selenium container have host network mode #143, Can't connect to PostgreSQL container from another container when running on Mac as host #138, could not translate host name "localnpipe" to address: Unknown host #108, MongoDbContainer on Windows 10 fails with getaddrinfo error #99 roughly fall into the category of ip and/or port resolution for different host systems and/or docker in docker (some of these could probably be classed as feature requests).
• OracleDbContainer() raises NotImplementedError #105 is a documentation issue (possibly also a bug but the issue isn't particularly clear); possible fix in Add missing _configure to OracleDbContainer #153.
• test is stuck at waiting and then times out : postgres container #101 reports connections timing out, possibly a duplicate of could not translate host name "localnpipe" to address: Unknown host #108 and/or MongoDbContainer on Windows 10 fails with getaddrinfo error #99.
• Docker compose example throws WebDriverException: Message: Error forwarding the new session Empty pool of VM for setup Capabilities {browserName: chrome, version: } #44 looks like a bug but I haven't dug into it.

Feature requests

• wait_for_logs fails for DockerCompose #144 to support wait_for_logs for docker compose (rather than just vanilla containers) with a proposed solution in [Fix/144] wait_for_logs working for DockerCompose #149
• Allow to specify dialect/driver when calling get_connection_url #140 for extension of get_connection_url api.
• TimeScaleDb container #126 (TimeScaleDb) and Supporting Ryuk container #104 (Ryuk) are requests for new container classes.
• Support for HTTP wait strategy #86 is looking for a wait strategy that checks by calling an HTTP endpoint in the container until it returns an ok status code.

PRs

• Fix readme link syntax #160, Add missing _configure to OracleDbContainer #153 are small PRs that are not going to have a material impact but we could just merge.
• adding rabbitmq container #51, added testcontainer for RabbitMQ #162, and Add container for RabbitMQ #142 are all trying to add RabbitMQ. Other container proposals include Add support for Trino #152 (Trino), Add Minio container support #148 (Minio), Added Kafka container to the supported containers #139 (Kafka).
• WIP: Host ip fix #154 and Improve host detection #158 try to address some of the ip and/or port issues.

I'm sure I've missed something, but maybe we can use this list as a starting point for next steps. Something we may want to think about longer-term is to allow different people to contribute their own containers without us having to be familiar with all the different databases as maintainers (maybe using CODEOWNERS, maybe using a template for others to publish their own packages (similar to what pytest has done with pytest-cov, pytest-mock, etc.)).

[KerstenBreuer]

@cal97g, @tillahoffmann thanks a lot for the feedback and @tillahoffmann thanks for giving the summary.

@SergeyPirogov, I hope my message was not misunderstood. I don't think that this repo is badly maintained. On the contrary, I see a lot of value in it and it could become a major component of our long-term software strategy. This is why, I would be happy to see this repo in the best possible shape with a high rate of community PRs being merged. If there is something I can help on, please let me know.

Either way, keep up the great work.

[KerstenBreuer]

@SergeyPirogov do you have any feedback or comment? Otherwise, I think this issue can be closed.

[yakimka]

@tillahoffmann @SergeyPirogov is this repository maintained? There are a lot of PR requests that no one answers for weeks or months. Are you sure you don't need help maintaining this repository?

[KerstenBreuer]

Hi @SergeyPirogov, @tillahoffmann,
I would really like this repo to be in the best possible shape. What it does is awesome and you are definitely very good maintainers.

However, since this project is becoming more and more popular it is only natural that it cannot be maintained by only two developers.

It seems that there are lots of volunteers for maintenance (@thedrow & @naomielst - see #177, @yakimka(?), and myself). I think it would be a great opportunity to make use of them.

It would be great if we can get some feedback from you.

[yakimka]

@SergeyPirogov, @tillahoffmann ?

[SergeyPirogov]

I will add anybody as a maintainer. Just leave your ids

[KerstenBreuer]

Great thanks so much for your trust. Here would be my id: @KerstenBreuer

[yakimka]

@SergeyPirogov?

[KerstenBreuer]

I have not received maintenance rights, yet. @thedrow, @naomielst what about you?

[SergeyPirogov]

@KerstenBreuer @thedrow you should have access

[KerstenBreuer]

Sorry, I didn't receive anything. Maybe, I was also too slow and the invite already expired?

[tillahoffmann]

I think everyone who's offered to contribute now has an invite. But let me know if that's not the case. @KerstenBreuer, I resent your invite.