Skip to content

Add missing _configure to OracleDbContainer #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2022
Merged

Add missing _configure to OracleDbContainer #153

merged 1 commit into from
Mar 26, 2022

Conversation

ebyhr
Copy link
Contributor

@ebyhr ebyhr commented Aug 13, 2021

Fixes #105

Confirmed test_docker_run_oracle succeeds in my environment.
Screen Shot 2021-08-13 at 16 34 53

@ebyhr
Copy link
Contributor Author

ebyhr commented Jan 28, 2022

Closing as there is no review more than 5 months.

@ebyhr ebyhr closed this Jan 28, 2022
@yakimka yakimka reopened this Mar 26, 2022
@yakimka
Copy link
Collaborator

yakimka commented Mar 26, 2022

@ebyhr thank you

Additionally, fix Oracle example.
@yakimka yakimka merged commit 6641b25 into testcontainers:master Mar 26, 2022
@ebyhr ebyhr deleted the ebi/fix-oracle branch March 28, 2022 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OracleDbContainer() raises NotImplementedError
2 participants