-
Notifications
You must be signed in to change notification settings - Fork 311
Add support for docker compose v2 #362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Seems edit: pushed a commit to drop it, but seems github is having some issues at the moment edit edit: the fix never got picked up by the PR for some reason, so squashed and force-pushed to get it in. should be good to go now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Glad to see more people looking at this! ❤️
I've got one small request but I'm no codeowner
so no "request changes")
@tillahoffmann a few of the tests were canceled, but I didn't see any errors in the logs... is there anything else needed for this one? |
They were cancelled because the tests timed out after a few hours. There are likely some issues with spinning up the containers. |
looks like I may need to add a comment to get the "requires attention" label back 😄 |
Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
Hey folks! I know things may be going slow right now, but I'd love to put some effort into #358 and would love to do so after this PR has been merged (likely to overhaul the compose package, but this contains some good ideas I want to keep) |
@tillahoffmann gentle ping |
The compose module was removed in #394 , so doesn't seem there's any need for this PR anymore... |
As said in #394 (comment), we are interested in bringing back support to Compose v2 without depending on the Python Docker Compose v1 dependency (so only delegating to the binary). Can this PR be adopted towards this approach? |
I understand the rationale for dropping the compose module. No hard feelings there 😄 As for adapting the PR... that's a possibility, though I'm not sure if/when I'd have the cycles... so and rather leaving the PR open indefinitely, I figured I'd go ahead and close it. If someone else wanted to resurrect it, that'd be okay with me too. |
Co-authored-by: Johannes Roos [email protected]
Fixes #306
Uses @jhnnsrs 's approach in #312 while refactoring to use the new structure post #290
Also tweaked the tests a bit so they would pass when using
docker compose