Skip to content

chore(deps): Allow Cypress 3 within peerDep. Updated Cypress and serve deps #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2018
Merged

chore(deps): Allow Cypress 3 within peerDep. Updated Cypress and serve deps #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cypress.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"baseUrl": "http://localhost:13370",
"videoRecording": false,
"screenshotOnHeadlessFailure": false
"video": false
}
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"test": "npm-run-all --parallel test:unit test:cypress",
"test:unit": "kcd-scripts test --no-watch",
"test:unit:watch": "kcd-scripts test",
"test:cypress:serve": "serve --clipless --local --port 13370 ./cypress/fixtures/test-app",
"test:cypress:serve": "serve -l 13370 ./cypress/fixtures/test-app",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change to shorthand? Has serve stopped supporting full nsmes for options?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, oversight on my part. Long version would be --listen

They did change their API quite drastically. Since it's missing from their docs, here's the help for easy reference.

  serve - Static file serving and directory listing

  USAGE
      $ serve --help
      $ serve --version
      $ serve [-l listen_uri [-l ...]] [directory]

      By default, serve will listen on 0.0.0.0:3000 and serve the
      current working directory on that address.

      Specifying a single --listen argument will overwrite the default, not supplement it.

  OPTIONS
      --help                              Shows this help message
      -v, --version                       Displays the current version of serve
      -l, --listen listen_uri             Specify a URI endpoint on which to listen (see below) -
                                          more than one may be specified to listen in multiple places
      -d, --debug                         Show debugging information
      -s, --single                        Rewrite all not-found requests to `index.html`

  ENDPOINTS
      Listen endpoints (specified by the --listen or -l options above) instruct serve
      to listen on one or more interfaces/ports, UNIX domain sockets, or Windows named pipes.

      For TCP ports on hostname "localhost":
          $ serve -l 1234
      For TCP (traditional host/port) endpoints:
          $ serve -l tcp://hostname:1234
      For UNIX domain socket endpoints:
          $ serve -l unix:/path/to/socket.sock
      For Windows named pipe endpoints:
          $ serve -l pipe:\\.\pipe\PipeName

"test:cypress:run": "cypress run",
"test:cypress:open": "cypress open",
"test:cypress": "npm-run-all --silent --parallel --race test:cypress:serve test:cypress:run",
Expand Down Expand Up @@ -42,13 +42,13 @@
"dom-testing-library": "^2.0.0"
},
"devDependencies": {
"cypress": "^2.1.0",
"cypress": "^3.0.1",
"kcd-scripts": "^0.37.0",
"npm-run-all": "^4.1.2",
"serve": "^6.5.6"
"serve": "^7.2.0"
},
"peerDependencies": {
"cypress": "^2.1.0"
"cypress": "^2.1.0 || ^3.0.0"
},
"eslintConfig": {
"extends": "./node_modules/kcd-scripts/eslint.js",
Expand Down