-
Notifications
You must be signed in to change notification settings - Fork 470
Decide what to do with getQueriesForElement
and within
#471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'd love to hear from other people. I'm not a fan of two ways to do the same thing (which is all aliases are), but I kind of like the way it reads in the different situations people use them in:
|
What about the third though, |
Oh, right, whoops, I honestly totally forgot about that and didn't even bother to read it because I assumed this was talking about the Yeah, let's get rid of |
I can repurpose the issue description to talk about Would you like to deprecate |
It's not been documented for a long time so I doubt anyone would be mad if we removed it. And renaming would be really trivial anyway. |
bindElementToQueries
getQueriesForElement
and within
Closes #471 BREAKING CHANGE: Use `getQueriesForElement` or `within` instead.
Describe the feature you'd like:
Decide whether to keep both
getQueriesForElement
andwithin
. I spoke to @kentcdodds on Twitter and he thinks that perhaps we should keep both. He suggested that I create an issue to discuss.If both are kept, perhaps the docs could be improved to help people decide between the two.
Suggested implementation:
Describe alternatives you've considered:
Teachability, Documentation, Adoption, Migration Strategy:
The text was updated successfully, but these errors were encountered: