test: Fix missing coverage for else-if #1013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5aac2b9:
|
Codecov Report
@@ Coverage Diff @@
## main #1013 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 914 916 +2
Branches 283 285 +2
=========================================
+ Hits 914 916 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 8.1.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix CI on
main(e.g. https://github.com/testing-library/dom-testing-library/runs/3419566094)Why:
No longer able to ignore the condition with Istanbul.
This was always an issue (gotwarlost/istanbul#781) but it seems like some updated dependency broke the previous workaround. Since we don't use lockfiles, we can't investigate when and why.
How:
Use "lonely-if" instead of
else-ifChecklist:
[ ]Documentation added to thedocs site
[ ]TypeScript definitions updated