get/query by value #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 8 8
Lines 138 145 +7
Branches 34 35 +1
=====================================
+ Hits 138 145 +7
Continue to review full report at Codecov.
|
alexkrolick
reviewed
May 6, 2018
src/__tests__/element-queries.js
Outdated
| </div> | ||
| `) | ||
|
|
||
| getByPlaceholderText('lastname').setAttribute('value', 'Norris') |
There was a problem hiding this comment.
Might be a bit more straightforward to start out with the value in the DOM, since the setAttribute part is JSDOM's responsibility. What do you think?
There was a problem hiding this comment.
makes sense, I updated the test.
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
get/query by value
Why:
as per discussion in #34
Note: setting .value on an element here somehow doesn't work, so i used .setAttribute. I linked it to my react project, and it worked with .value just fine. Not sure what's going on here.
I changed the selector part here to * instead of [${attribute}] to verify that that's not the cause:
but it didn't change anything.
Another note, related to that, in my original implementation in my project I used a selector for getting all inputs, I guess if someone set an attribute value on a div, current implementation would get that element as well - not sure how much we want to prevent such edge cases. It's a decision between complicating the code a bit, and making sure we treat values only when they are actually input values.
How:
Following the existing pattern
Checklist: