Skip to content

Fix link in README #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2018
Merged

Fix link in README #6

merged 1 commit into from
Apr 7, 2018

Conversation

gnapse
Copy link
Member

@gnapse gnapse commented Apr 6, 2018

Though I'd rather move this section about "query APIs" to be right inside the "Usage" section at the end of it, after all the get* functions. This would remove the need for the link in the first place.

Also I was wondering if it's intentional to have getByTestId missing from the table of content and with a deeper level of nesting in the README outline than the other get* functions.

@codecov
Copy link

codecov bot commented Apr 6, 2018

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #6   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          85     85           
  Branches       24     24           
=====================================
  Hits           85     85

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6efd07...205b9c1. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit 075528d into testing-library:master Apr 7, 2018
@gnapse gnapse deleted the pr/fix-readme-link branch April 7, 2018 02:43
@kentcdodds
Copy link
Member

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants