-
Notifications
You must be signed in to change notification settings - Fork 470
Feature: adds aria-expanded filter to *ByRole #821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: adds aria-expanded filter to *ByRole #821
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ea73b2a:
|
Codecov Report
@@ Coverage Diff @@
## master #821 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 934 941 +7
Branches 286 289 +3
=========================================
+ Hits 934 941 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, though I wonder if this has an impact on *ByRole
's performance
I imagine the impact on performance comes before --- the change affects filtering logic that comes after that. I am wondering though, given that in this instance we're filtering by an attribute, wouldn't it be possible to replace that |
Create a benchmark, measure and share the results. I believe I checked this in the past and only observed negligible gains. |
🎉 This PR is included in version 7.29.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What: Adds an
expanded
filter to*ByRole
queries.Why: Allow supporting roles to be filtered by the
aria-expanded
widget attribute.How: Implemented in a similar pattern as other attribute filters.
Checklist:
docs site