-
Notifications
You must be signed in to change notification settings - Fork 470
fix(types): allow all elements #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cdc5980:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Here's the CI failure:
I think it's something wrong with the Unfortunately this is completely unrelated to this PR, but we should probably get it fixed before merging anything else. |
I'm also not opposed to just disabling the rule for now. |
Yeah that rule is not in the recommended list yet until it gets a little more vetting. There is a PR in flight that addresses some stability on the rule though. |
testing-library/eslint-plugin-jest-dom#107 fixes the crash but then we get 76 lint errors, so I'll disable it and we can fix those issues separately. |
@nickmccurdy the rule is autofixing. fwiw. :) |
Codecov Report
@@ Coverage Diff @@
## master #834 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 934 934
Branches 286 286
=========================================
Hits 934 934
Continue to review full report at Codecov.
|
Co-authored-by: Sebastian Silbermann <[email protected]>
Hi folks, |
Port of testing-library/react-testing-library#833
Checklist:
docs site