RFC: fixer for wait (V7)

[timdeschryver]

Would it be an option to add a fixable rule for the changes made to wait?
The implementation could look like this

export default function(context) {
  return {
    "CallExpression > Identifier[name=wait]"(node) {
      context.report({
        node: node,
        message: "waitForRename",
        fix: fixer => fixer.replaceText(node, "waitFor")
      });
    },
    "CallExpression[callee.name=waitFor][arguments.length=0]"(node) {
      context.report({
        node: node,
        message: "emptyCallBack",
        fix: fixer => fixer.replaceText(node, "waitFor(() => {})")
      });
    }
  };
}

input:

async () => {
	await wait(() => {});
  	await wait();
}

output:

async () => {
	await waitFor(() => {});
  	await waitFor(() => {});
}

[Belco90]

This seems really interesting! I guess the rule could be called something like prefer-wait-for and we could also check waitForDomChange right? The replace would be the same I think.

I'll give it a try tomorrow.

[timdeschryver]

@Belco90 yep that should work, see the updated astexplorer for an implementation of the rule

[Belco90]

This will be released on v3

[Belco90]

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀