Skip to content

feat: remove prefer-wait-for rule #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/propose_new_rule.yml
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ body:
attributes:
label: Name for new rule
description: Suggest a name for the new rule that follows the [rule naming conventions](https://github.com/testing-library/eslint-plugin-testing-library/blob/main/CONTRIBUTING.md#rule-naming-conventions).
placeholder: prefer-wait-for
placeholder: prefer-find-by
validations:
required: true

1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -231,7 +231,6 @@ To enable this configuration use the `extends` property in your
| [`prefer-query-by-disappearance`](./docs/rules/prefer-query-by-disappearance.md) | Suggest using `queryBy*` queries when waiting for disappearance | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][] |
| [`prefer-screen-queries`](./docs/rules/prefer-screen-queries.md) | Suggest using `screen` while querying | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][] |
| [`prefer-user-event`](./docs/rules/prefer-user-event.md) | Suggest using `userEvent` over `fireEvent` for simulating user interactions | | |
| [`prefer-wait-for`](./docs/rules/prefer-wait-for.md) | Use `waitFor` instead of deprecated wait methods | 🔧 | |
| [`render-result-naming-convention`](./docs/rules/render-result-naming-convention.md) | Enforce a valid naming for return value from `render` | | ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][] |

<!-- RULES-LIST:END -->
74 changes: 0 additions & 74 deletions docs/rules/prefer-wait-for.md

This file was deleted.

214 changes: 0 additions & 214 deletions lib/rules/prefer-wait-for.ts

This file was deleted.

2 changes: 1 addition & 1 deletion tests/index.test.ts
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@ import plugin from '../lib';
const execAsync = util.promisify(exec);
const generateConfigs = () => execAsync(`npm run generate:configs`);

const numberOfRules = 27;
const numberOfRules = 26;
const ruleNames = Object.keys(plugin.rules);

// eslint-disable-next-line jest/expect-expect
2,258 changes: 0 additions & 2,258 deletions tests/lib/rules/prefer-wait-for.test.ts

This file was deleted.