v6.0.0 #796
Merged
v6.0.0 #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `prefer-wait-for` is now removed
BREAKING CHANGE: `no-render-in-setup` is now called `no-render-in-lifecycle`
BREAKING CHANGE: `no-manual-cleanup` is now enabled by default in the React & Vue configs
…660) BREAKING CHANGE: `no-global-regexp-flag-in-query` is now enabled by default in all configs
…or `user-event` (#652) BREAKING CHANGE: `await-fire-event` is now called `await-async-event`
BREAKING CHANGE: `no-node-access` is now enabled by default in the DOM config
…default (#663) BREAKING CHANGE: `no-debugging-utils` now enables all debug methods in all configs by default
BREAKING CHANGE: `no-await-sync-query` is now called `no-await-sync-queries`
…fault (#667) BREAKING CHANGE: `no-await-sync-events` is now enabled by default in the DOM, Angular & React configs
BREAKING CHANGE: `await-async-query` is now called `await-async-queries`
# Conflicts: # README.md # docs/rules/await-fire-event.md # docs/rules/no-render-in-lifecycle.md # docs/rules/prefer-wait-for.md # lib/rules/await-fire-event.ts # tests/__snapshots__/index.test.ts.snap # tests/index.test.ts # tests/lib/rules/await-fire-event.test.ts
# Conflicts: # README.md # lib/rules/no-debugging-utils.ts # tests/index.test.ts
Belco90
added
BREAKING CHANGE
|
I need to install the |
|
Tested by installing the alpha in other projects. All good! |
Comment on lines
+33
to
+35
| dom: ['error', { eventModule: 'userEvent' }], | ||
| angular: ['error', { eventModule: 'userEvent' }], | ||
| react: ['error', { eventModule: 'userEvent' }], |
There was a problem hiding this comment.
Should we use an array here as well for consistency?
Suggested change
| dom: ['error', { eventModule: 'userEvent' }], | |
| angular: ['error', { eventModule: 'userEvent' }], | |
| react: ['error', { eventModule: 'userEvent' }], | |
| dom: ['error', { eventModule: ['userEvent'] }], | |
| angular: ['error', { eventModule: ['userEvent'] }], | |
| react: ['error', { eventModule: ['userEvent'] }], |
There was a problem hiding this comment.
Both ways are accepted, and we are only setting one value, so it's fine.
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
Changes
This PR contains all the changes for v6.0.0. You can install it via the
alphatag before it gets released officially.Context
n/a