Skip to content

Make each interface public #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2019
Merged

Make each interface public #111

merged 2 commits into from
Jun 30, 2019

Conversation

VinceMalone
Copy link

What:

Make each interface public for use in explicit types, rather than relying on the implicit typing from renderHook.

Why:

Implicit types often work just fine, but I've run into a case where I want to reference the typing (related to renderHook) in something like a shared utility.

For example:

import { RenderHookResult, renderHook } from '@testing-library/react-hooks';

const results = new Set<RenderHookResult<unknown, void>>();

How:

By exporting each interface

Checklist:

  • Typescript definitions updated
  • Ready to be merged
  • Added myself to contributors table

@codecov-io
Copy link

Codecov Report

Merging #111 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #111   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          39     39           
  Branches        3      3           
=====================================
  Hits           39     39

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 590a5d9...f082371. Read the comment docs.

@mpeyper
Copy link
Member

mpeyper commented Jun 29, 2019

Looks good. I don't have time to do a publish a release at the moment (end of financial year in Oz and I work in financial services) so I'll merge this in a few days.

@mpeyper mpeyper merged commit 396049b into testing-library:master Jun 30, 2019
@VinceMalone VinceMalone deleted the pr/public-interfaces branch June 30, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants