Skip to content

Move type dependencies to peer dependencies. #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Move type dependencies to peer dependencies. #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbf9727
make type dependencies peer deps.
ericmackrodt Jul 10, 2019
37dfbd9
Update contributors.
ericmackrodt Jul 10, 2019
26b7c55
update docs
ericmackrodt Jul 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .all-contributorsrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,15 @@
"contributions": [
"code"
]
},
{
"login": "ericmackrodt",
"name": "Eric Mackrodt",
"avatar_url": "https://avatars3.githubusercontent.com/u/450616?s=180&v=4",
"profile": "http://ericmackrodt.com",
"contributions": [
"code"
]
}
],
"commitConvention": "none"
Expand Down
10 changes: 6 additions & 4 deletions docs/introduction/setup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,16 @@ npm install --save-dev @testing-library/react-hooks
### Peer Dependencies

`react-hooks-testing-library` does not come bundled with a version of
[`react`](https://www.npmjs.com/package/react) or
[`react-test-renderer`](https://www.npmjs.com/package/react-test-renderer) to allow you to install
the specific version you want to test against. Generally, the installed versions for `react` and
`react-test-renderer` should match:
[`react`](https://www.npmjs.com/package/react),
[`react-test-renderer`](https://www.npmjs.com/package/react-test-renderer) or their specific types
to allow you to install the specific version you want to test against. Generally, the installed
versions for `react` and `react-test-renderer` should match:

```sh
npm install react@^x.y.z
npm install --save-dev react-test-renderer@^x.y.z
npm install --save-dev @types/react@^x.y.z
npm install --save-dev @types/react-test-renderer@^x.y.z
```

Both of these dependecies must be installed as at least version `16.8.0` to be compatible with
Expand Down
Loading