Added global cleanup

[marquesm91]

What:

Added global cleanup

Why:

To ease the cleanup tests using a global setup file

How:

Added in root cleanup-after-each.js to require cleanup function and call inside afterEach

Checklist:

• Documentation updated
• Tests
• Typescript definitions updated
• Ready to be merged
• Added myself to contributors table

I don't add anything to Documentation because react-testing-library don't. But if it is necessary I can complete cleanup() section with an example

Closes #13

[codecov-io]

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #16   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          18     18           
=====================================
  Hits           18     18

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 595b7f8...90eb946. Read the comment docs.

[mpeyper]

Can you please add a section to the README about the usage of this cleanup helper?

Other than that this is great, thanks!

[mpeyper]

I should have read the description better as you explicitly mentioned documentation.

I think your suggestion of adding it to the cleanup() section is good.

[marquesm91]

Added instructions in cleanup section. If you think it needs some more explatin let me know!

[mpeyper]

Thanks @marquesm91. I'll put together a release for this later (I really need to automate this).

[jljorgenson18]

It looks like all of the cleanup functionality was removed. Is there any particular reason why?

[mpeyper]

Hi @jljorgenson18,

Yes, we changed the renderer from react-testing-library to react-test-renderer. One of the consequences of this change was that the test component we wrap the hook in is not rendered into a shared DOM anymore, so there is nothing to actually clean up between tests.

[jljorgenson18]

Got it. Rendering though is only one facet to cleanup. If you have a side effect in useEffect (like a window event listener), would the cleanup function returned from useEffect get called?

[mpeyper]

We never handled that explicitly (perhaps we should?). Usually you would unmount the hook yourself, triggering the cleanup, or handle your own specific cleanup yourself in a beforeEach or afterEach block.